Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaConchFirstPass display option #507

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dericed
Copy link
Contributor

@dericed dericed commented Jan 15, 2017

No description provided.

@ablwr
Copy link
Member

ablwr commented Jan 15, 2017

Oo la la

@ablwr
Copy link
Member

ablwr commented Jan 15, 2017

Yes! Tested all of these and look good to me. 👍

@JeromeMartinez
Copy link
Member

What is the purpose of MediaConchFirstPass.xsl?
It is not clear, and we are missing a "description" block.

@dericed
Copy link
Contributor Author

dericed commented Jan 16, 2017

It is for some characterization, but the policy is set up differently. It would be like:

<policy type="or" name="categorize these files">
 <policy type="and" name="Final Cut Capture">...</policy>
 <policy type="and" name="Camera Recording">...</policy>
 <policy type="and" name="Final Cut Export">...</policy>
 <policy type="and" name="Unknown File">...</policy>
</policy>

output would be:

filename1,Final Cut Capture
filename2,Unknown file
filename3,Camera Recording
filename4,Camera Recording

@JeromeMartinez
Copy link
Member

I think MediaConchFirstPass should have a more relevant name. Not sure of which one, but here this is not clear.

@dericed
Copy link
Contributor Author

dericed commented Jan 16, 2017

FirstPass is meaning First Passing sub-policy or rule, but sure the naming could be improved. @ablwr?

@ablwr
Copy link
Member

ablwr commented Jan 16, 2017

FirstToPass or QuickPass? Although unsure if it is actually much 'quicker'...

It seems like a FirstFail would be more useful?

@JeromeMartinez
Copy link
Member

It is not quicker, so -1 for it.
FirstToPass: First what? --> FirstRuleToPass? (even if "Rule" is technically not correct because it is sub-policy or rule, the idea is there)

@dericed
Copy link
Contributor Author

dericed commented Jan 17, 2017

Does the user interact with the file name? I don't think CSV and First2Pass make much sense in the GUI where a report is viewed for a single record at a time. But how should these be in the CLI?

MediaConchCSV

  • mediaconch -p policy.xml -fc some.mov files.mkv > yay.csv

MediaConchSimple

  • mediaconch -p policy.xml -fs some.mov files.mkv

For scalability perhaps we should have long names as alias.

  • -fx = --format xml = --format x
    etc

@ablwr
Copy link
Member

ablwr commented Jan 17, 2017

-fx == --format=xml (which already exists)
-fc == --format=csv
-fs == --format=simple ?

@ablwr
Copy link
Member

ablwr commented Jan 17, 2017

But what is the use case for FirstPass (to be renamed or not)?

@dericed
Copy link
Contributor Author

dericed commented Jan 17, 2017

todo: documentation, but generally the idea is to categorize media with a set of top-level policies and report on the first matching one. Some top level policies to detect if it is final cut capture, then another for media express capture, an access file, a mezzanine, etc. Then if you have a large set of random files this policy would group them by a type.

@ablwr
Copy link
Member

ablwr commented Jan 17, 2017

I see. Contingent on this very specific use case of the first policy being the most important and set up in this particular way so that it may direct files out accordingly.

@dericed
Copy link
Contributor Author

dericed commented Jan 17, 2017

A bit inspired by the archivematica FPR as they have to categorize files and act according to that. The semantics are a bit off in this case though as pass/fail doesn't seem as appropriate, but it's more like match/not-match.

@JeromeMartinez
Copy link
Member

From my point of view FirstPass is too much specific (and looks like an hack :) ), and should not be in the default installation, but should go in a "public display" page (@GuillaumeRoques will like the idea ;-) ).

Each display has some concerns (e.g. CSV output would not work well when we get 2 implementation checkers and 2 formats are in the list of parsed), I suggest to open 1 PR per display in order to not mix discussions.

@dericed
Copy link
Contributor Author

dericed commented Jan 18, 2017

Right, csv presumes the values of the first implementation check for each subsequent file. I could restrict it to Matroska. I can split the PR tonight.

@JeromeMartinez JeromeMartinez changed the title new display options! MediaConchFirstPass display option Jan 24, 2017
@JeromeMartinez
Copy link
Member

CSV and Simple are added (#522, #523, #524).

I let this one open for discussion about MediaConchFirstPass.xsl.
Issue:

  • looks like a (good) hack, maybe not for general availability but for a public display page. In the meanwhile it could be used by sending the XSL to the interested people.
  • Shouldn't we ad somewhere a description, with some indication about the purpose of the XSL? I am afraid that someone new can not understand it. then we could e.g. add an help option that provides this description with the command line (and the GUI could have a tooltip, for other displays)

@ablwr
Copy link
Member

ablwr commented Apr 18, 2017

This is old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants